feat: reuse connections and limit the number of connections for preheating #3683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements to the
manager/job/preheat.go
file, primarily focusing on enhancing the HTTP client configuration and refactoring the code for better maintainability.HTTP Client Configuration Improvements:
defaultHTTPTransport
variable to define the default HTTP transport settings, including maximum idle connections, maximum connections per host, and idle connection timeout.preheat
struct to include anhttpClient
field, and updated thenewPreheat
function to initialize this client with thedefaultHTTPTransport
settings.getImageLayers
method to use thehttpClient
from thepreheat
struct instead of creating a new HTTP client each time.Code Refactoring:
newImageAuthClient
function to use thedefaultHTTPTransport
for its HTTP client, ensuring consistent transport settings across different parts of the codebase.Related Issue
Fixed #3635.
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist