feat: optimize error message of preheating #3622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on improving error handling in the
manager
package by providing more detailed error messages. The most important changes include updating error messages in theError
middleware and enhancing error context in thefindSchedulers
andfindCandidateSchedulers
service methods.Error handling improvements:
manager/middlewares/error.go
: Updated the error message in the GORM error handler to useerr.Error()
instead of a generic HTTP status text.manager/service/job.go
: Enhanced error context in thefindSchedulers
method by including the scheduler cluster ID in the error message.manager/service/job.go
: Enhanced error context in thefindCandidateSchedulers
method by including the scheduler cluster ID in the error message.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist