Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DefaultFilteredQueryParams for job #3608

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: add DefaultFilteredQueryParams for job #3608

merged 1 commit into from
Oct 28, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 28, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 28, 2024
@gaius-qi gaius-qi self-assigned this Oct 28, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 28, 2024 13:00
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (5a51a61) to head (6f952e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/service/job.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3608      +/-   ##
==========================================
- Coverage   35.71%   35.68%   -0.04%     
==========================================
  Files         339      335       -4     
  Lines       37326    37294      -32     
==========================================
- Hits        13332    13309      -23     
+ Misses      23151    23144       -7     
+ Partials      843      841       -2     
Flag Coverage Δ
unittests 35.68% <40.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/manager/docs.go 0.00% <ø> (ø)
pkg/strings/strings.go 100.00% <100.00%> (ø)
manager/service/job.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 90d2017 into main Oct 28, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/filter branch October 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants