Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add self-signed certs for mTLS #3583

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: add self-signed certs for mTLS #3583

merged 1 commit into from
Oct 16, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 16, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 16, 2024
@gaius-qi gaius-qi self-assigned this Oct 16, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 16, 2024 14:04
scheduler/resource/standard/peer.go Dismissed Show dismissed Hide dismissed
@gaius-qi gaius-qi force-pushed the feature/certs branch 2 times, most recently from 0126f5e to 984ba36 Compare October 16, 2024 15:06
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.31%. Comparing base (5ab6450) to head (84ac6b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/standard/seed_peer.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
- Coverage   36.44%   36.31%   -0.14%     
==========================================
  Files         335      335              
  Lines       31129    31112      -17     
==========================================
- Hits        11346    11299      -47     
- Misses      18951    18974      +23     
- Partials      832      839       +7     
Flag Coverage Δ
unittests 36.31% <88.88%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/config/config.go 87.57% <ø> (-0.98%) ⬇️
scheduler/resource/standard/peer.go 71.84% <100.00%> (-0.14%) ⬇️
scheduler/resource/standard/resource.go 63.63% <100.00%> (ø)
scheduler/service/service_v1.go 79.28% <100.00%> (ø)
scheduler/service/service_v2.go 78.75% <100.00%> (-0.13%) ⬇️
scheduler/resource/standard/seed_peer.go 25.00% <50.00%> (-0.69%) ⬇️

... and 5 files with indirect coverage changes

@gaius-qi gaius-qi requested a review from a team as a code owner October 16, 2024 15:57
@gaius-qi gaius-qi requested a review from hyy0322 October 16, 2024 15:57
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 5c52a02 into main Oct 16, 2024
25 of 27 checks passed
@gaius-qi gaius-qi deleted the feature/certs branch October 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants