Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed network topology #3547

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: removed network topology #3547

merged 1 commit into from
Sep 30, 2024

Conversation

gaius-qi
Copy link
Member

Because no one maintains it and has no users run in the production

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 30, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 30, 2024
@gaius-qi gaius-qi self-assigned this Sep 30, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 30, 2024 09:34
@gaius-qi
Copy link
Member Author

This pull request involves the removal of the network topology feature from the codebase. The changes focus on simplifying the configuration, validation, and daemon operations by eliminating related structures, methods, and tests.

Removal of Network Topology Feature:

  • Configuration Cleanup:

    • Removed NetworkTopologyOption and ProbeOption types from client/config/peerhost.go.
    • Deleted network topology settings from client/config/constants.go, client/config/peerhost_darwin.go, client/config/peerhost_linux.go, and client/config/testdata/config/daemon.yaml. [1] [2] [3] [4]
  • Daemon Simplification:

    • Removed network topology initialization, serving, and stopping logic from client/daemon/daemon.go. [1] [2] [3]
    • Deleted the networktopology package and its mock implementations. [1] [2]
  • Validation and Testing:

    • Removed validation logic for network topology from client/config/peerhost.go.
    • Updated tests to remove network topology-related test cases from client/config/peerhost_test.go. [1] [2]
  • Dependency and Configuration Updates:

    • Updated go.mod to remove unused dependencies. [1] [2]
    • Removed network topology-related Redis keys and configurations from pkg/redis/redis.go. [1] [2] [3]
    • Updated Docker and Helm configurations to reflect the removal of network topology settings. [1] [2] [3]
  • Miscellaneous:

    • Removed unused methods from client/daemon/peer/peertask_dummy.go.
    • Simplified the bucket listing logic in manager/rpcserver/manager_server_v1.go by removing redundant cache handling.

Because no one maintains it and has no users run in the production

Signed-off-by: Gaius <[email protected]>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.69%. Comparing base (bd8ecfb) to head (cdc3b39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/rpcserver/manager_server_v1.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   51.81%   49.69%   -2.13%     
==========================================
  Files         190      186       -4     
  Lines       20481    19511     -970     
==========================================
- Hits        10613     9696     -917     
+ Misses       9062     9020      -42     
+ Partials      806      795      -11     
Flag Coverage Δ
unittests 49.69% <95.00%> (-2.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/peerhost.go 46.98% <ø> (-0.48%) ⬇️
client/config/peerhost_linux.go 100.00% <ø> (ø)
client/daemon/peer/peertask_dummy.go 22.22% <ø> (+1.53%) ⬆️
pkg/redis/redis.go 45.83% <ø> (-14.78%) ⬇️
scheduler/config/config.go 88.54% <100.00%> (-1.33%) ⬇️
scheduler/metrics/metrics.go 8.24% <ø> (ø)
scheduler/rpcserver/rpcserver.go 100.00% <100.00%> (ø)
scheduler/rpcserver/scheduler_server_v1.go 3.84% <100.00%> (+0.39%) ⬆️
scheduler/rpcserver/scheduler_server_v2.go 1.94% <100.00%> (+0.10%) ⬆️
scheduler/scheduling/evaluator/evaluator.go 83.33% <100.00%> (-1.05%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit 8d956eb into main Sep 30, 2024
27 of 29 checks passed
@gaius-qi gaius-qi deleted the feature/network branch September 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants