Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update api version to v2.0.158 and update helm chart #3527

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

BruceAko
Copy link
Contributor

@BruceAko BruceAko commented Sep 23, 2024

Description

  1. Update api version.
  2. Add methods for scheduler rpcserver.
  3. Update helm chart.

Commands:

go get -u d7y.io/api/v2
go mod tidy

Related Issue

#3523

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@BruceAko BruceAko requested a review from a team as a code owner September 23, 2024 15:08
@BruceAko BruceAko force-pushed the update-api branch 2 times, most recently from 973d203 to a891609 Compare September 23, 2024 15:26
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (b1875df) to head (954f1a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/rpcserver/scheduler_server_v2.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
- Coverage   52.10%   52.01%   -0.10%     
==========================================
  Files         190      190              
  Lines       20432    20434       +2     
==========================================
- Hits        10647    10628      -19     
- Misses       8981     8998      +17     
- Partials      804      808       +4     
Flag Coverage Δ
unittests 52.01% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/rpcserver/scheduler_server_v2.go 2.63% <0.00%> (-0.08%) ⬇️

... and 6 files with indirect coverage changes

@BruceAko BruceAko closed this Sep 24, 2024
@BruceAko BruceAko reopened this Sep 24, 2024
@BruceAko BruceAko closed this Sep 24, 2024
@BruceAko BruceAko reopened this Sep 24, 2024
@BruceAko BruceAko closed this Sep 24, 2024
@BruceAko BruceAko reopened this Sep 24, 2024
@BruceAko BruceAko changed the title chore: update api version to v2.0.158 and update helm chart chore: update api version to v2.0.159 and update helm chart Sep 24, 2024
@BruceAko BruceAko changed the title chore: update api version to v2.0.159 and update helm chart chore: update api version to v2.0.158 and update helm chart Sep 24, 2024
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c9180af into dragonflyoss:main Sep 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants