Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize trigger download task return empty #2958

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 19, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 19, 2023
@gaius-qi gaius-qi self-assigned this Dec 19, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 19, 2023 10:10
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2958 (9df25c5) into main (ec66fd1) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2958   +/-   ##
=======================================
  Coverage   51.03%   51.03%           
=======================================
  Files         161      161           
  Lines       21904    21899    -5     
=======================================
- Hits        11179    11177    -2     
+ Misses      10063    10060    -3     
  Partials      662      662           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.03% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/resource/seed_peer.go 23.35% <100.00%> (ø)
scheduler/resource/seed_peer_client_mock.go 24.32% <100.00%> (-0.68%) ⬇️
scheduler/service/service_v2.go 84.93% <100.00%> (-0.05%) ⬇️
scheduler/resource/seed_peer_mock.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 0c591e4 into main Dec 19, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/trigger branch December 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant