Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize piece download failed handler #2883

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat: optimize piece download failed handler #2883

merged 1 commit into from
Nov 14, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Nov 14, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 14, 2023
@gaius-qi gaius-qi self-assigned this Nov 14, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 14, 2023 14:27
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2883 (e6d2492) into main (86ce09f) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 76.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   50.97%   50.95%   -0.02%     
==========================================
  Files         161      161              
  Lines       21746    21760      +14     
==========================================
+ Hits        11084    11088       +4     
- Misses      10001    10009       +8     
- Partials      661      663       +2     
Flag Coverage Δ
unittests 50.95% <76.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/scheduling/scheduling.go 81.91% <100.00%> (+0.07%) ⬆️
scheduler/service/service_v2.go 85.16% <71.42%> (-0.40%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 79b4aab into main Nov 14, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/failed branch November 14, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants