Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ListSeedPeers feature in manager #2865

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 8, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Nov 8, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 8, 2023
@gaius-qi gaius-qi self-assigned this Nov 8, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 8, 2023 08:15
yxxhero
yxxhero previously approved these changes Nov 8, 2023
@gaius-qi gaius-qi force-pushed the feature/manager branch 3 times, most recently from ce8724c to af7f203 Compare November 8, 2023 10:53
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2865 (5f617f6) into main (39a15e1) will decrease coverage by 0.19%.
Report is 3 commits behind head on main.
The diff coverage is 6.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   51.53%   51.35%   -0.19%     
==========================================
  Files         162      161       -1     
  Lines       21851    21931      +80     
==========================================
  Hits        11262    11262              
- Misses       9922    10005      +83     
+ Partials      667      664       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.35% <6.97%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/redis/redis.go 75.00% <100.00%> (+0.92%) ⬆️
scheduler/scheduling/scheduling.go 84.65% <100.00%> (ø)
scheduler/service/service_v2.go 84.89% <100.00%> (ø)
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 5f4fe57 into main Nov 8, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/manager branch November 8, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants