-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preheat image supports authentication and parse multi manifest mediatype #2819
preheat image supports authentication and parse multi manifest mediatype #2819
Conversation
@Panlq Please fix lint. |
|
Codecov Report
@@ Coverage Diff @@
## main #2819 +/- ##
==========================================
- Coverage 52.08% 51.55% -0.53%
==========================================
Files 157 162 +5
Lines 21364 21851 +487
==========================================
+ Hits 11127 11265 +138
- Misses 9590 9921 +331
- Partials 647 665 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: jonpan <[email protected]>
…mediatype Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
…ion code.) Signed-off-by: jonpan <[email protected]>
Signed-off-by: jonpan <[email protected]>
38b1ffc
to
0ac9180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Panlq Please add E2E testing in https://github.com/dragonflyoss/Dragonfly2/blob/main/test/e2e/manager/preheat.go.
Changes in new features are compatible with the original e2e test content!so there is no need to add anything else? |
@Panlq Unit testing and E2E testing are two different things. Please add E2E testing in https://github.com/dragonflyoss/Dragonfly2/blob/main/test/e2e/manager/preheat.go and resolved conflicting. |
Signed-off-by: jonpan <[email protected]>
b47e979
to
68cbb95
Compare
I know, what I want to express is that the original e2e has already involved image type testing, and is also compatible with new code. I am familiar with the existing e2e use cases and add the scenario of specifying platform parameters. The auth(account and password) cannot be written in them |
You can send me the image, and I will upload it to dragonfly's group in docker hub for E2E testing. I think you should need to add multi-platform E2E test cases. |
@Panlq |
ok, I think I can use busybox:latest (amd64/arm64) to write e2e use cases |
You can use |
Signed-off-by: jonpan <[email protected]>
|
Signed-off-by: jonpan <[email protected]>
cefaf71
to
44e9ec3
Compare
Signed-off-by: jonpan <[email protected]>
44e9ec3
to
eaf60e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related Issue
#769
Motivation and Context
Supports direct preheating of private registry images
Screenshots (if appropriate)
Types of changes
Checklist