Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: otelgrpc.UnaryClientInterceptor memory leak #2772

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix: otelgrpc.UnaryClientInterceptor memory leak #2772

merged 1 commit into from
Oct 8, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 8, 2023

Description

Fix refer to PR argoproj/argo-cd#15174, See open-telemetry/opentelemetry-go-contrib#4226 for more information.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 8, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 8, 2023
@gaius-qi gaius-qi self-assigned this Oct 8, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner October 8, 2023 07:16
…ple Int64Histogram resulting in a memory leak

Signed-off-by: Gaius <[email protected]>
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #2772 (971e07f) into main (a3f2aae) will decrease coverage by 0.11%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   52.45%   52.34%   -0.11%     
==========================================
  Files         157      157              
  Lines       21235    21248      +13     
==========================================
- Hits        11138    11123      -15     
- Misses       9450     9479      +29     
+ Partials      647      646       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 52.34% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/rpc/interceptor.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3b55ae4 into main Oct 8, 2023
@gaius-qi gaius-qi deleted the fix/otel branch October 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants