Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client grpc dial non-block #2261

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 11, 2023

Description

We need add timeout for grpc dialing, according docs: https://github.com/grpc/grpc-go/blob/v1.54.0/clientconn.go#L119, we should add grpc.WithBlock() to dial options.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner April 11, 2023 09:01
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #2261 (1f20f34) into main (f6a3c7e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
+ Coverage   49.61%   49.62%   +0.01%     
==========================================
  Files         146      146              
  Lines       19513    19513              
==========================================
+ Hits         9682     9684       +2     
  Misses       9233     9233              
+ Partials      598      596       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/daemon/peer/peertask_piecetask_synchronizer.go 52.55% <100.00%> (+0.90%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit bb38e04 into main Apr 12, 2023
@gaius-qi gaius-qi deleted the fix/client-grpc-dial-non-block branch April 12, 2023 03:38
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants