chore(tiering): Range functions + small refactoring #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dranikpg
commented
Jun 22, 2024
•
dranikpg
commented
- STRLEN had an important bug
- Add support for range functions
- Remove some unnecessary code
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
changed the title
dranikpg
force-pushed
the
string-family
branch
2 times, most recently
from
017f038
to
c73206f
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
|
Suspiciously the mixed append test is failing, shouldn't be triggered by this code 🤨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.