Feature/issue entry association

app/assets/stylesheets/shared/_icons.scss

@@ -0,0 +1,11 @@
+.fa-check {
+  color: $green;
+}
+
+.fa-info-circle {
+  color: $blue;
+}
+
+.fa-times {
+  color: $red;
+}

app/assets/stylesheets/shared/_validations.scss

@@ -1,29 +1,18 @@
 .validation {
-  .fa-check {
-    color: $green;
-  }
-
-  .fa-info-circle {
-    color: $blue;
-  }
-
-  .fa-times {
-    color: $red;
-  }
-
   &.validation-feed {
     .validation-list {
+      list-style-type: none;
       margin: 1rem 0 0;
       padding: 0;
 
       li {
         i {
-          margin-right: .15rem;
+          margin-right: 0.15rem;
         }
 
         .text-error {
           font-size: 90%;
-          margin: 0 0 .5rem 1.3rem;
+          margin: 0 0 0.5rem 1.6rem;
         }
 
         &:last-of-type .text-error {

app/assets/stylesheets/tylium.scss

@@ -23,6 +23,7 @@
 @import 'shared/datatables';
 @import 'shared/editor_toolbar';
 @import 'shared/empty_state.scss';
+@import 'shared/icons';
 @import 'shared/inline_editable';
 @import 'shared/mixins';
 @import 'shared/noscript';

app/assets/stylesheets/tylium/modules/_buttons.scss

@@ -49,6 +49,23 @@
   }
 }
 
+.btn-link {
+  background-color: transparent;
+  border: none;
+  color: $linkColor;
+  padding: 0;
+  text-decoration: none;
+
+  &:active,
+  &:focus,
+  &:hover,
+  &:not(:disabled):not(.disabled):active {
+    background-color: transparent;
+    box-shadow: none !important;
+    color: $linkColorHover;
+  }
+}
+
 .btn-placeholder {
   align-items: center;
   background-color: $primaryColor;

app/assets/stylesheets/tylium/modules/_dots-menu.scss

@@ -10,7 +10,7 @@
 
   .dots-dropdown-header {
     font-weight: 400 !important;
-    
+
     &:hover {
       color: $linkColor !important;
       background-color: initial !important;
@@ -21,6 +21,10 @@
       margin-top: 0.3rem;
       padding-top: 0.3rem;
     }
+
+    &:not(:has(+ .dropdown-item)) {
+      display: none;
+    }
   }
 
   .dropdown-menu {

app/assets/stylesheets/tylium/modules/_modals.scss

@@ -1,16 +1,16 @@
 .modal {
-
   .modal-dialog {
-    max-width: 560px;
+    &:not(.modal-lg, .modal-xl) {
+      max-width: 560px;
+    }
 
     .modal-content {
       font-size: 0.9rem;
 
       .modal-body {
-
         .add_multiple_nodes_form {
           display: none;
-        
+
           .add_multiple_nodes_error {
             display: none;
             color: #b94a48;
@@ -49,7 +49,6 @@
   }
 
   &#modal_delete_node {
-
     ul {
       list-style: disc;
       padding-left: 30px;
@@ -70,7 +69,7 @@
         text-decoration: underline !important;
       }
     }
-    
+
     .invalid-selection {
       cursor: not-allowed;
     }
@@ -109,13 +108,12 @@
   }
 
   &#try-pro {
-
     .modal-dialog {
       max-width: 80%;
-  
+
       .modal-body {
         height: 80vh;
-    
+
         iframe {
           border: none;
           top: 0;
@@ -125,7 +123,7 @@
           width: 100%;
         }
       }
-  
+
       .modal-header h5 span {
         color: $primaryColor;
       }

app/models/concerns/has_fields.rb

@@ -11,13 +11,22 @@ def local_fields
   # Extract a Title file if one exists.
   def title
     fields.fetch(
-      "Title",
-      "(No #[Title]# field)"
+      'Title',
+      '(No #[Title]# field)'
     )
   end
 
   def title?
-    fields["Title"].present?
+    fields['Title'].present?
+  end
+
+  private
+
+  def update_container(container_field, updated_fields)
+    self.send(
+      :"#{container_field}=",
+      FieldParser.fields_hash_to_source(updated_fields)
+    )
   end
 
   module ClassMethods
@@ -52,14 +61,17 @@ def dradis_has_fields_for(container_field)
       define_method :set_field do |field, value|
         # Don't use 'fields' as a local variable name or it conflicts with the
         # #fields getter method
-        updated_fields        = fields
+        updated_fields = fields
         updated_fields[field] = value
-        self.send(
-          :"#{container_field}=",
-          updated_fields.to_a.map { |h| "#[#{h[0]}]#\n#{h[1]}" }.join("\n\n")
-        )
+        self.update_container(container_field, updated_fields)
+      end
+
+      # Completely removes the field (field header and value) from the content
+      define_method :delete_field do |field|
+        updated_fields = fields
+        updated_fields.except!(field)
+        self.update_container(container_field, updated_fields)
       end
     end
   end
-
 end

app/models/field_parser.rb

@@ -1,19 +1,15 @@
 class FieldParser
   FIELDS_REGEX = /#\[(.+?)\]#[\r|\n](.*?)(?=#\[|\z)/m
-  FIELDLESS_REGEX = /^([\s\S]*?)(?=\n{,2}#\[.+?\]#|\z)/
+  HEADERLESS_REGEX = /^([\s\S]*?)(?=\n{,2}#\[.+?\]#|\z)/
 
   # Convert serialized form data to Dradis-style item content.
   def self.fields_to_source(serialized_form)
-    serialized_form.each_slice(2).map do |field_name, field_value|
-      field = field_name[:value]
-      value = field_value[:value]
-
-      str = ''
-      str << "#[#{field}]#\n" unless field.empty?
-      str << "#{value}" unless value.empty?
+    serialized_form.each_slice(2).map(&to_source).compact.join("\n\n")
+  end
 
-      str
-    end.compact.join("\n\n")
+  # Convert a hash of field name/value pairs to Dradis-style item content.
+  def self.fields_hash_to_source(fields)
+    fields.map(&to_source).compact.join("\n\n")
   end
 
   # Parse the contents of the field and split it to return a Hash of field
@@ -38,7 +34,7 @@ def self.source_to_fields(string)
   #   #[Description]#
   #   Lorem ipsum...
   #
-  # If the string contains a fieldless string, it will be prepended to
+  # If the string contains a headerless field, it will be prepended to
   # the result. E.g.
   #
   #   Line 1
@@ -54,18 +50,33 @@ def self.source_to_fields_array(string)
       field.map(&:strip)
     end
 
-    fieldless_string = parse_fieldless_string(string)
+    headerless_fields = parse_fields_without_headers(string)
 
-    if fieldless_string.present?
-      array.prepend(['', fieldless_string])
+    if headerless_fields.present?
+      array.prepend(['', headerless_fields])
     end
 
     array
   end
 
-  # Field-less strings are strings that do not have a field header (#[Field]#).
+  # Headerless fields are strings that do not have a field header (#[Field]#).
   # This parses all characters before a field header or end of string.
-  def self.parse_fieldless_string(source)
-    source[FIELDLESS_REGEX, 1]
+  def self.parse_fields_without_headers(source)
+    source[HEADERLESS_REGEX, 1]
+  end
+
+  private
+
+  def self.to_source
+    return Proc.new do |field, value|
+      field = field.is_a?(String) ? field.to_s : field[:value]
+      value = value.is_a?(String) ? value.to_s : value[:value]
+
+      str = ''
+      str << "#[#{field}]#\n" unless field.empty?
+      str << value unless value.empty?
+
+      str
+    end
   end
 end