Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dracut): don't apply aggressive strip to kernel modules #2673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryncsn
Copy link
Contributor

@ryncsn ryncsn commented Sep 13, 2024

Unlike ordinary binaries, kernel module will be unusable if stripped with "-p". Fix this by always use "-g" only.

So far it didn't cause many issues since most kernels have their modules signed or compressed so this is skipped.

This pull request changes...

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

@ryncsn ryncsn changed the title fix(dracut): when aggressive strip is enabled, don't apply to ko fix(dracut): don't apply aggressive strip to kernel modules Sep 13, 2024
Unlike ordinary binaries, kernel module will be unusable if stripped
with "-p". Fix this by always use "-g" only.

So far it didn't cause many issues since most kernels have their
modules signed or compressed so this is skipped.

Signed-off-by: Kairui Song <[email protected]>
@daveyoung
Copy link
Contributor

Hi @ryncsn , the development of orginal dracut repo is stalled, the latest dracut upstream is https://github.com/dracut-ng/dracut-ng I think you can close this one and repost to dracut-ng

@ryncsn
Copy link
Contributor Author

ryncsn commented Sep 13, 2024

Hi @ryncsn , the development of orginal dracut repo is stalled, the latest dracut upstream is https://github.com/dracut-ng/dracut-ng I think you can close this one and repost to dracut-ng

Hi Dave,

Thanks for the info, I'll open another PR then. I saw the last PR in this repo was 2 weeks ago and didn't notice this.

Copy link

stale bot commented Jan 21, 2025

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale communication is stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants