-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip test 50,60 if ifcfg dracut module can not be installed #2543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @bdrung
Please provide a reasoning in the git commit. At least these tests were failing on Debian/Ubuntu (see also bug #2328). |
@bdrung Thanks for the review. I added more reasoning to the git commit message.
As to your question, these tests are only meant to run if ifcfg dracut module is supported. |
Thanks.
That information could go into the commit message as well, saying something like: Instead of disabling the test, they should be reimplement so that they do not require ifcfg dracut module in the future. |
Test 50 and 60 have a dependency on the ifcfg dracut module. If ifcfg dracut module is not available, than the preconditions for these tests are not met. Since ifcfg dracut module is not available in many Linux enviroments (such as Arch or Debian), it make sense to explicitelly skip these tests instead of failing them as they are simply not applicable to many Linux distributions in their current form. Instead of disabling the tests, they should be reimplement so that they do not require ifcfg dracut module in the future.
okay. I updated the commit message. Thanks @bdrung |
Test 50 and 60 have a dependency on the ifcfg dracut module.
If ifcfg dracut module is not available, than the preconditions
for these tests are not met.
Since ifcfg dracut module is not available in many Linux enviroments
(such as Arch or Debian), it make sense to explicitelly skip these
tests instead of failing them as they are simply not applicable
to many Linux distributions in their current form.