fix(45ifcfg): mark as deprecated and strictly opt-in

[jlebon]

The 45ifcfg module should be considered deprecated now since ifcfg files themselves are deprecated. They've been replaced by e.g. NetworkManager keyfiles or systemd-networkd files.

Currently, the 45ifcfg module checks if the /etc/sysconfig/network-scripts directory exists to know if to automatically get pulled in. However, on systems with NetworkManager, this directory always exists even if the functionality to read ifcfg files is disabled by default (NM kindly ships a README in there to ease migrating to keyfiles).

Since almost everyone should've already migrated to a more modern alternative, let's make this module purely opt-in now.

Checklist

• I have tested it locally
• I have reviewed and updated any documentation if relevant
• I am providing new code and test(s) for it

[jlebon]

/cc @thom311 @bengal

[jlebon]

An alternative is to tweak the conditional to check whether the directory is non-empty (skipping over the README) to know if ifcfg files are in use, but that creates a bootstrapping problem where you want ifcfg files generated on first boot to get propagated there in the first place. I also wanted to see if we could have a stronger stance on this and maybe eventually get rid of that module entirely.

[aafeijoo-suse]

TEST-60-BONDBRIDGEVLANIFCFG using the network-legacy module in Fedora needs to be addressed: https://github.com/dracutdevs/dracut/actions/runs/6353041817/job/17256980641?pr=2529#step:4:1186

The ifcfg module is required and not automatically included. See an old run, e.g.: https://github.com/dracutdevs/dracut/actions/runs/6309637128/job/17129970526?pr=2527#step:4:101

Apart from that, I'm ok with deprecating RH-specific code, or removing this module if it's no longer needed.

[bengal]

Makes sense to me, ifcfg support is also being deprecated in NetworkManager and will be removed eventually.

[jlebon]

TEST-60-BONDBRIDGEVLANIFCFG using the network-legacy module in Fedora needs to be addressed: dracutdevs/dracut/actions/runs/6353041817/job/17256980641?pr=2529#step:4:1186

The ifcfg module is required and not automatically included. See an old run, e.g.: dracutdevs/dracut/actions/runs/6309637128/job/17129970526?pr=2527#step:4:101

Hmm OK, I'm not sure if I'm following the testing code properly. Do I just need a -m network-legacy here?

[LaszloGombos]

Hmm OK, I'm not sure if I'm following the testing code properly. Do I just need a -m network-legacy here?

@jlebon can you please try to add this and see if that resolves the regression with TEST-60. Thanks !

diff --git a/test/TEST-60-BONDBRIDGEVLAN/test.sh b/test/TEST-60-BONDBRIDGEVLAN/test.sh
index 5110ddb1..a10630dc 100755
--- a/test/TEST-60-BONDBRIDGEVLAN/test.sh
+++ b/test/TEST-60-BONDBRIDGEVLAN/test.sh
@@ -367,7 +367,7 @@ test_setup() {
     "$DRACUT" -l -i "$TESTDIR"/overlay / \
         --no-early-microcode \
         -o "plymouth" \
-        -a "debug ${USE_NETWORK}" \
+        -a "debug ${USE_NETWORK} ifcfg" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1

[jlebon]

Hmm OK, I'm not sure if I'm following the testing code properly. Do I just need a -m network-legacy here?

@jlebon can you please try to add this and see if that resolves the regression with TEST-60. Thanks !

Ahhh thanks. My mind got mixed up while looking at the test code and was thinking about network-legacy instead of ifcfg.

Looks like that fixes it, though there are other tests that failed. Seems like we'll need to tweak a few others.

[LaszloGombos]

Looks like that fixes it, though there are other tests that failed. Seems like we'll need to tweak a few others.

Remaining test failures are not regressions, they are existing failures. PR LGTM.

[stale]

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.