fix(rootfs-block): remove support for [no]readonlyroot and fastboot #2264
Conversation
github-actions
bot
added
modules
LaszloGombos
added
enhancement
LaszloGombos
force-pushed
the
readonlyroot
branch
from
806979e to
86d80d8
Compare
LaszloGombos
changed the title
LaszloGombos
force-pushed
the
readonlyroot
branch
from
86d80d8 to
5b291e9
Compare
| @@ -30,21 +30,12 @@ mount_root() { | |||
| fsck_ask_err | |||
| done | |||
|
|
|||
| READONLY= | |||
| fsckoptions= | |||
| if [ -f "$NEWROOT"/etc/sysconfig/readonly-root ]; then | |||
There was a problem hiding this comment.
Old RH pre-systemd stuff: https://access.redhat.com/solutions/2196881
I'd remove the /etc/sysconfig/readonly-root part as well.
There was a problem hiding this comment.
Thanks for the feedback. Since I am not very familiar with RedHat and the history here, I'd like to proceed with extra caution.
That said if others think there are more conditions that could be removed here, I am open to combine it with this PR.
This PR removes some obsolete and undocumented functionality from a core dracut module. "readonlyroot" and "noreadonlyroot" command line option are no longer supported. Use "ro" or "rw" instead.
LaszloGombos
force-pushed
the
readonlyroot
branch
from
5b291e9 to
2cfee2c
Compare
LaszloGombos
changed the title
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
This PR removes a command line option for a core dracut module.
"readonlyroot" and "noreadonlyroot" command line option are no longer supported (not sure if they actually ever fully worked).
Use "ro" or "rw" instead.
I am open to keep these arguments and document them instead of removing them, but since there is a much more prevalent command line alternative, I do not think these are used."
Original commit from 2010: 3871942
Fixes #1948 (partially)