-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network-wicked): remove module #2129
Conversation
wicked is being phased out from openSUSE https://news.opensuse.org/2022/01/28/bash-systemd-libvirt-update-in-tw/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, as I didn't want this module in the first place. However, I'd like a transition timeline from @aafeijoo-suse before we yank it completely.
If this is accepted upstream, I'll send an email to the Factory mailing list with the warning notice. I don't think any other distro ships wicked, so the timeline can be managed downstream. If 058 is released too early, I'll wait for 059 and keep the module only in openSUSE. |
We should be able to strip all the way down to only support iwd and sd-networkd if we want to limit the amount of available network support upstream. |
Since I was planning on trying to make a release in the next couple of days what is too early? |
Interesting given that you weren't actively involved with the project nor expressed your "opinion" in the review process when Daniel made the PR for wicked being included, where did you express your opinion that you did not want this module included in the first place? Somewhere in the (open)suse community? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acking @aafeijoo-suse can just merge this when he feels it's ready
Then I'd merge this for 059, so I do not have to carry it downstream only. |
I was working with @danimo on the entire upstreaming process in person during the openSUSE Conference in 2019. Again, just because my name isn't written on every commit doesn't mean I didn't do work on it. I worked with him to eliminate 900 patches from dracut and upstream most of it. Stop being a jerk to me about this. I'm really tired of it. |
Fedora and Bottlerocket OS ship Wicked in the distribution. I packaged I will be retiring Wicked from Fedora shortly after this module is removed from Dracut upstream. |
wicked is being phased out from openSUSE
https://news.opensuse.org/2022/01/28/bash-systemd-libvirt-update-in-tw/
I think having less networking option would help the project focus on quality.
From my limited amount of testing, running tests in the openSUSE container with network-wicked both NFS (test 20) and NBD (test 40) are failing. In the same openSUSE container these tests are passing both with network-manager and with network-legacy.
Since the network meta module prefers network-wicked over network-manager and with network-legacy - by default - just installing wicked on the host system would likely result in networking not working in the generated initramfs.