Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network-wicked): remove module #2129

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

LaszloGombos
Copy link
Collaborator

@LaszloGombos LaszloGombos commented Dec 15, 2022

wicked is being phased out from openSUSE
https://news.opensuse.org/2022/01/28/bash-systemd-libvirt-update-in-tw/

I think having less networking option would help the project focus on quality.

From my limited amount of testing, running tests in the openSUSE container with network-wicked both NFS (test 20) and NBD (test 40) are failing. In the same openSUSE container these tests are passing both with network-manager and with network-legacy.

Since the network meta module prefers network-wicked over network-manager and with network-legacy - by default - just installing wicked on the host system would likely result in networking not working in the generated initramfs.

@github-actions github-actions bot added github Issues related to .github modules Issue tracker for all modules network Issues related to the network module network-legacy Issues related to the network-legacy module labels Dec 15, 2022
@LaszloGombos LaszloGombos added the opensuse Issue tracker for the OpenSuse distribution label Dec 19, 2022
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, as I didn't want this module in the first place. However, I'd like a transition timeline from @aafeijoo-suse before we yank it completely.

@aafeijoo-suse
Copy link
Member

This makes sense to me, as I didn't want this module in the first place. However, I'd like a transition timeline from @aafeijoo-suse before we yank it completely.

If this is accepted upstream, I'll send an email to the Factory mailing list with the warning notice. I don't think any other distro ships wicked, so the timeline can be managed downstream. If 058 is released too early, I'll wait for 059 and keep the module only in openSUSE.

@johannbg
Copy link
Collaborator

johannbg commented Dec 21, 2022

I think having less networking option would help the project focus on quality.

We should be able to strip all the way down to only support iwd and sd-networkd if we want to limit the amount of available network support upstream.

@johannbg
Copy link
Collaborator

If 058 is released too early, I'll wait for 059 and keep the module only in openSUSE.

Since I was planning on trying to make a release in the next couple of days what is too early?

@johannbg
Copy link
Collaborator

This makes sense to me, as I didn't want this module in the first place.

Interesting given that you weren't actively involved with the project nor expressed your "opinion" in the review process when Daniel made the PR for wicked being included, where did you express your opinion that you did not want this module included in the first place? Somewhere in the (open)suse community?

Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acking @aafeijoo-suse can just merge this when he feels it's ready

@aafeijoo-suse
Copy link
Member

Since I was planning on trying to make a release in the next couple of days what is too early?

Then I'd merge this for 059, so I do not have to carry it downstream only.

@Conan-Kudo
Copy link
Member

Conan-Kudo commented Dec 21, 2022

This makes sense to me, as I didn't want this module in the first place.

Interesting given that you weren't actively involved with the project nor expressed your "opinion" in the review process when Daniel made the PR for wicked being included, where did you express your opinion that you did not want this module included in the first place? Somewhere in the (open)suse community?

I was working with @danimo on the entire upstreaming process in person during the openSUSE Conference in 2019. Again, just because my name isn't written on every commit doesn't mean I didn't do work on it. I worked with him to eliminate 900 patches from dracut and upstream most of it.

Stop being a jerk to me about this. I'm really tired of it.

@Conan-Kudo
Copy link
Member

Conan-Kudo commented Dec 21, 2022

This makes sense to me, as I didn't want this module in the first place. However, I'd like a transition timeline from @aafeijoo-suse before we yank it completely.

If this is accepted upstream, I'll send an email to the Factory mailing list with the warning notice. I don't think any other distro ships wicked, so the timeline can be managed downstream. If 058 is released too early, I'll wait for 059 and keep the module only in openSUSE.

Fedora and Bottlerocket OS ship Wicked in the distribution. I packaged wicked for Fedora as a favor to the Amazon Linux/Bottlerocket teams (HT @stewartsmith and @nmeyerhans) for their integration of Wicked downstream, but Bottlerocket has decided to move away from Wicked now (bottlerocket-os/bottlerocket#2449) and Amazon Linux 2022 doesn't ship it at all.

I will be retiring Wicked from Fedora shortly after this module is removed from Dracut upstream.

@johannbg johannbg added this to the dracut-059 milestone Dec 21, 2022
@aafeijoo-suse aafeijoo-suse merged commit 9dbbebb into dracutdevs:master Dec 28, 2022
@LaszloGombos LaszloGombos deleted the wicked branch December 28, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github modules Issue tracker for all modules network Issues related to the network module network-legacy Issues related to the network-legacy module opensuse Issue tracker for the OpenSuse distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants