Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recolor heads-up notification #46

Closed
ajitid opened this issue Jul 12, 2017 · 1 comment
Closed

Recolor heads-up notification #46

ajitid opened this issue Jul 12, 2017 · 1 comment

Comments

@ajitid
Copy link
Contributor

ajitid commented Jul 12, 2017 •
edited
Loading

VS Code 1.14 breaks colors of label and button of heads-up notification
capture

New keys are in this issue: microsoft/vscode#28280

Can you also revert terminal's background color? Output, Problems and Debug Console all having same bg color but Terminal having a different bg color feels strange.

If you've provided color to title bar in Mac, then update its screenshot in readme too.
@dsifford
Copy link
Member

Thanks for the heads up (pun intended!)

I'll try to get to this soon. Going to also implement the terminal color adjustments that were suggested in dracula/dracula-theme#232

@ajitid ajitid changed the title Recolor heads-up notification 1.14 theme improvements Jul 15, 2017
@ajitid ajitid changed the title 1.14 theme improvements VSCode 1.14 theme improvements Jul 15, 2017
@ajitid ajitid changed the title VSCode 1.14 theme improvements Recolor heads-up notification Aug 12, 2017
dsifford added a commit that referenced this issue Aug 12, 2017
@dsifford
various improvements
289870b 
- Fix issue on insiders causing null colors to default to red.
- Add color for new dialog UI scopes.
- Revert terminal bg color in attempt to improve contrast.

Closes #50, #46, #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsifford @ajitid