-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange pink highlight in some words - is this by design? #248
Comments
Hmm, looks like the |
@benknoble you are right! There was a line in my Now I get:
Thank you for your help! |
Unfortunately for the moment, this is "intended"… due to a quirk (#192 #210 ) that neovim & vim use (slightly) different highlight groups for trailing whitespace, which we would like to be more subtle. Vim uses SpecialKey, which also get's used for stuff like If you really don't like it, one simple fix is augroup dracula_custom
autocmd!
autocmd ColorScheme dracula highlight! link SpecialKey DraculaPink
augroup END (or whatever your preferred color is) |
@benknoble Neovim uses |
@dsifford I would like to revisit the issues I linked above at some point (I think #210 is the most relevant). To me it's worth making vim's listchars stuff a little more visible if it makes other UI elements that use the same group easier to deal with. (And, note, vim doesn't use just The other option would be to try to get vim to use a different/new group for list chars ( |
Definitely open to making those changes. Happy to put our heads together if you want to get a PR started. |
Related: #192, #210, #248 Also #247 is about `NonText`, which needs investigating. Issues: `:digraphs`, special keys in `:map` output, and certain parts of `'listchars'` are "subtle" and hard to read (esp. w/ `cursorline` over them). Also, vim uses `SpecialKey` for them (instead of `Whitespace` for `'listchars'` and `SpecialKey` elsewhere, like NeoVim). Fix: make `SpecialKey` more like special keys (the highlight in vimscript for, e.g., `map <Space> :echo "hello"<CR>`). This has the side effect of making digraphs more visible. It also makes certain `'listchars'` pink, which may be annoying. But there is no way currently to separate the two in vim. Rationale: It matches with the special keys in maps. The fact that vim uses it elsewhere may simply be "wrong" and need changed. If you don't like it: well, as usual, you can use an autocommand to use whatever colors you want (`:help dracula-customization`).
Related: #192, #210, #248 Also #247 is about `NonText`, which needs investigating. Issues: `:digraphs`, special keys in `:map` output, and certain parts of `'listchars'` are "subtle" and hard to read (esp. w/ `cursorline` over them). Also, vim uses `SpecialKey` for them (instead of `Whitespace` for `'listchars'` and `SpecialKey` elsewhere, like NeoVim). Fix: make `SpecialKey` more like special keys (the highlight in vimscript for, e.g., `map <Space> :echo "hello"<CR>`). This has the side effect of making digraphs more visible. It also makes certain `'listchars'` pink, which may be annoying. But there is no way currently to separate the two in vim. Rationale: It matches with the special keys in maps. The fact that vim uses it elsewhere may simply be "wrong" and need changed. If you don't like it: well, as usual, you can use an autocommand to use whatever colors you want (`:help dracula-customization`).
I think this is resolved, so I'll close it for now. Let us know if it is not resolved. |
@benknoble I apologize, I missed the notification for your mention. Thank you for working on this! |
What happened
Some words in vim appear highlighted with pink color. For example, when using Tagbar plugin for
go
language outline, or at the intro screen of VIM.What I expected to happen
This highlight is irritating, is this a bug or just a design decision?
Screenshot
At right bottom is the Tagbar with the pink highlights:
Another case, at the vim intro screen:
The following screenshot is what I get when I run vim without loading plugins, which means with Dracula for vim disabled (still I have Dracula theme for my gnome-terminal enabled):
Machine Info
Linux Dellis 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
vim
/gvim
/neovim
): vimTERM
environment variable: screenThe text was updated successfully, but these errors were encountered: