Fix height of button on SDDM login #241
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with the SDDM login screen. The background of the button was set to an absolute height of
30
, but the element itself was taller. As a result, there is an unequal amount of spacing between the top of the button and the bottom of the button, as can be seen in this screenshot prior to the final change (ignore that the button is max width, that was just me testing):I have changed the background to instead match the height of the parent element, which results in the text being correctly vertically aligned in the center of the button:
Apologies for the camera shots instead of screenshots, I didn't have a VM to make the changes in, I did it on my host machine