Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn this in the a FreeCAD Preference Pack #2

Closed
luzpaz opened this issue Feb 20, 2022 · 9 comments
Closed

Turn this in the a FreeCAD Preference Pack #2

luzpaz opened this issue Feb 20, 2022 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@luzpaz
Copy link

luzpaz commented Feb 20, 2022

See https://github.com/Chrismettal/FreeCAD-Behave-Dark-Preference-Pack

Edit: FreeCAD-Behave was added to the Addon Manager (see FreeCAD/FreeCAD-addons@0d23295)

ref: FreeCAD/FreeCAD-addons#201

@eleanor-clifford
Copy link
Member

Hi @luzpaz, if you want to make this change I'd be happy to review a PR. Unfortunately I don't have the time to work on it right now.

@luzpaz
Copy link
Author

luzpaz commented Feb 20, 2022

Possibly. Can you add a 'Help Wanted' to this ticket JIC anyone else is inspired ?

@eleanor-clifford eleanor-clifford added the help wanted Extra attention is needed label Feb 21, 2022
@Chrismettal
Copy link
Contributor

To turn this into a preference pack, don't we need to first include this stylesheet into FreeCADs source @luzpaz ?

If the stylesheet was packaged into FreeCAD I would like to wrap it into a Preference Pack, but I don't know what the current consensus is regarding getting "every" stylesheet into the FreeCAD source.

@luzpaz
Copy link
Author

luzpaz commented May 25, 2022

To turn this into a preference pack, don't we need to first include this stylesheet into FreeCADs source @luzpaz ?

I don't think so. Preference packs operate independently of core FreCAD, right @chennes ? (he's AFK till later this week)

Edit: reference: https://forum.freecadweb.org/viewtopic.php?f=8&t=58210

@Chrismettal
Copy link
Contributor

That's how it worked for the Behave theme at least. The Preference pack chooses the already included stylesheet and sets all the colors not already set by the sheet.

I'm not sure if a preference pack alone is able to set all colors that the stylesheet usually sets.

@luzpaz
Copy link
Author

luzpaz commented May 26, 2022

Oh interesting. Didn't know that.

@chennes
Copy link

chennes commented May 26, 2022

You can include the stylesheet withe the pack, it does not have to be part of the FreeCAD distribution.

@Chrismettal
Copy link
Contributor

I have opened up PRs to refactor this repo into a PreferencePack, as well as distribute it with the internal addon manager.

You can try it out without merging by adding my fork to your FreeCADs addon manager custom repo list like this:

image

Searching for preference packs via the addon manager and installing the fork:

image

And lastly applying it from within preferences:

image

@eleanor-clifford
Copy link
Member

closed by #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

4 participants