Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Stylesheet] ExtremeProDark #226

Closed
MisterMakerNL opened this issue Jul 4, 2022 · 11 comments
Closed

[New Stylesheet] ExtremeProDark #226

MisterMakerNL opened this issue Jul 4, 2022 · 11 comments
Labels
New WB/Addon 📦 New contribution to the Addon repo preference-pack

Comments

@MisterMakerNL
Copy link
Contributor

It's just a style-sheet no need for a lot of text for explaining link, its a in my opinion better version of the prodark.
Also the pro dark dev doesn't seem to react anymore or update his code.
https://github.com/MisterMakerNL/ExtremeProDark

@MisterMakerNL MisterMakerNL added the New WB/Addon 📦 New contribution to the Addon repo label Jul 4, 2022
@luzpaz
Copy link
Collaborator

luzpaz commented Jul 4, 2022

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Jul 5, 2022

@luzpaz I added it!
I also added some links to prodark and vertui I think at least one of theme I used as a source but I don't know anymore. I modified enough that it is a theme on it's own.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 5, 2022

Nice, giving props to @turn211 and @StudioPetrikas 😉

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 5, 2022

@MisterMakerNL this stylesheet works on master, correct?

@MisterMakerNL
Copy link
Contributor Author

Yes, but it also has the overlay settings for linkstage. But master just ignores that, so works good on master.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 5, 2022

@chennes can we merge this ?

@Chrismettal
Copy link

Don't we need to package it as a complete PreferencePack to provide it via the addon manager?
The original ProDark follows the packaging format as well and I don't see a reason to stray from the norm here. In the past stylesheets were included in FreeCADs source directly, and now we supply them via the addon manager as PreferencePacks.

See also the guide to PreferencePack structure

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 11, 2022

@MisterMakerNL is this not a preference pack per the metadata package.xml wiki page?

@MisterMakerNL
Copy link
Contributor Author

I just copied it from pro-dark. :)

@Chrismettal
Copy link

Can you make sure your pack conforms to the structure specified completely, and then try to manually install your pack with the addon manager in the same way as described here, by manually adding your packs repo as an addon source:

dracula/freecad#2 (comment)

If that works, you can open up a PR to this repo, adding your pack, and testers can try your pack out the same way before merging.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 15, 2022

Closing in favor of #229

@luzpaz luzpaz closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New WB/Addon 📦 New contribution to the Addon repo preference-pack
Projects
None yet
Development

No branches or pull requests

3 participants