-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types: Fix importing non-default types #185
base: main
Are you sure you want to change the base?
Conversation
Please notice I created 3 separate commits.
|
Forget it, it works fine in CJS, and in TS/CJS it works if you enable |
After a quick test this seems to work fine. At least my project isn't complaining when I switch from my PR to this 🙂. Last week I did however run into an issue with the types "parseUri" function, so if you could update that as well I think that I can close my PR in favour of yours. I use the following locally, but I haven't had the energy to check if any values could be export function parseUri(uri: string): {
scheme: string,
user: string;
password: string,
host: string;
port: number,
params?: Record<string, any>;
headers?: Record<string, string>;
}; Edit: I just checked the source code, and parseUri doesn't account for "tel:"-addresses. I suppose this would be more correct: export function parseUri(uri: string): {
family?: string,
scheme: string,
user?: string | undefined;
password?: string | undefined,
host?: string;
port?: number;
number?: string;
context?: string | null;
params: Record<string, any>;
headers?: Record<string, string>;
}; It's not pretty but I believe it's accurate. |
Fixed, thanks for letting me know. |
Fixes #181.