Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel reason #10

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Cancel reason #10

wants to merge 3 commits into from

Conversation

danjenkins
Copy link
Contributor

@danjenkins danjenkins commented Nov 13, 2019

Enable cancel reasons to be propagated from the original request in

Enable us sending our own reason if the call was answered by a different leg in the fork.

I had issues getting the propagation working @davehorton - should res be available where I expect it to in the cancel listener?

fixes #7

@davehorton
Copy link
Collaborator

Yes, that usage looks correct. But there is no Reason header being applied on the outbound cancel request?

@danjenkins
Copy link
Contributor Author

@davehorton res on this.req.on('cancel', (res) => { is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to set headers in the CANCELs emitted by the simringer
2 participants