Support get_mode, set_mode, get_color, set_color#4
Merged
dr1rrb merged 2 commits intodr1rrb:mainfrom Jan 13, 2022
Merged
Conversation
22 tasks
Owner
|
Finally got a chance to try it, and once I updated the firmware of my device it works perfectly. Even if we are expecting to move away from this client in HA, there is no reason to not merge it, thanks! |
Owner
|
Package is now available here https://pypi.org/manage/project/twinkly-client/release/0.0.3/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support modes and color functionality. This should make it possible to add support for RGB/RGBW lighting features in HA. I added a little cli helper script too, which I'm currently using for a template light in HA.
Just as I was finishing this up I saw there's a PR for using another lib for twinkly in HA.. oh well, let's see where this takes us.