fetch commit offsets in base consumer unless group is None #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
changed the title
| if not partitions: | ||
| partitions = self.client.get_partition_ids_for_topic(self.topic) | ||
|
|
||
| def get_or_init_offset(resp): | ||
| for partition in partitions: |
There was a problem hiding this comment.
Would it be possible to send the offset requests for all partitions at once?
There was a problem hiding this comment.
good call -- adding a commit for that
Tweak MP Consumer test to use iterator
a group is configured (but document that group must be None for old servers). This fixes multiprocessor consumer issue that prevented access to commit offsets if auto_commit is disabled. Also refactor fetch_last_known_offsets based on KafkaConsumer While still setting unknown offsets to 0
This was referenced Mar 30, 2015
dpkp
added a commit
that referenced
this pull request
Mar 31, 2015
fetch commit offsets in base consumer unless group is None
This was referenced Mar 31, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #173 (and #347) w/ included test case from @alisaifee