Properly destroying the objects that contain daemonized threads #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you submit pep8 fixes / ae0017c separately? |
|
Yes.
Actually I did this commit to trigger a travis build on my clone and check
that the build was passing before doing a pull request (I don't know how
else to do).
I will remove the pep8ification.
|
chmduquesne
force-pushed
the
master
branch
5 times, most recently
from
e797f62 to
45b9797
Compare
|
I have removed the pep8 fix, and rebased my patch onto master, so that this can be merged with a fast forward. Travis reports an error on this pull request, but I don't understand why: on my clone, it does not complain. Can you relaunch the incriminated build? |
|
not sure what is going on w/ tests -- |
dpkp
added a commit
that referenced
this pull request
Mar 3, 2015
Properly destroying the objects that contain daemonized threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer, Producer and ReentrantTimer all create daemonized threads. Problem: when destroying these objects, the daemonized threads are not destroyed and the threads live forever with no mean to reach them.
This created issue #323, which I could deal with by using stop() manually, but there is no reason to force the user to force the user to do that when it could be dealt with automatically.
This pull request fixes this.