Add retry and queue size on async producer #283
Conversation
Add retry on async producer in case of send failure. Default set to 3 retry with a back retry set to 300 ms Add capabilities to limit the size of the async queue in order to avoid having too much memory consumption by this queue if the async process is not able to send messages fastly.
| log.exception("Unable to send message - retry {0}".format(i)) | ||
| time.sleep(float(batch_send_retry_backoff_ms) / float(1000)) | ||
| continue | ||
| break |
There was a problem hiding this comment.
Shouldn't this break be in the try?
There was a problem hiding this comment.
In the try or out the try do the same.
We continue if we face an exception or we break if no exception.
|
What's the status of this PR? it's been 4+ months, same with #304 @dpkp - you mentioned something about Rdio having their own, perhaps you can get that committed to upstream? or get this patch in? |
|
I'd like to get #331 merged for this issue instead. If you have a second to review, would appreciate more eyeballs and/or testing. |
|
#331 is merged and supports this via |
Add retry on async producer in case of send failure. Default set to 3
retry with a back retry set to 300 ms
Add capabilities to limit the size of the async queue in order to avoid
having too much memory consumption by this queue if the async process
is not able to send messages fastly.