Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MultiProcessConsumer to start each child consumer from current offset. #252

Closed
wants to merge 2 commits into from
Closed

Allow MultiProcessConsumer to start each child consumer from current offset. #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
663580e
added parameter for child consumers to load their offsets on init
mahall Oct 2, 2014
2e9bfbf
forgot to add load_initial_offsets to SimpleConsumer as well as Consumer
mahall Oct 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kafka/consumer/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ class Consumer(object):
"""
def __init__(self, client, group, topic, partitions=None, auto_commit=True,
auto_commit_every_n=AUTO_COMMIT_MSG_COUNT,
auto_commit_every_t=AUTO_COMMIT_INTERVAL):
auto_commit_every_t=AUTO_COMMIT_INTERVAL,
load_initial_offsets=False):

self.client = client
self.topic = topic
Expand All @@ -65,7 +66,7 @@ def __init__(self, client, group, topic, partitions=None, auto_commit=True,
self.commit)
self.commit_timer.start()

if auto_commit:
if auto_commit or load_initial_offsets:
self.fetch_last_known_offsets(partitions)
else:
for partition in partitions:
Expand Down
11 changes: 7 additions & 4 deletions kafka/consumer/multiprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
log = logging.getLogger("kafka")


def _mp_consume(client, group, topic, chunk, queue, start, exit, pause, size):
def _mp_consume(client, group, topic, chunk, queue, start, exit, pause, size, load_initial_offsets):
"""
A child process worker which consumes messages based on the
notifications given by the controller process
Expand All @@ -37,7 +37,8 @@ def _mp_consume(client, group, topic, chunk, queue, start, exit, pause, size):
partitions=chunk,
auto_commit=False,
auto_commit_every_n=None,
auto_commit_every_t=None)
auto_commit_every_t=None,
load_initial_offsets=load_initial_offsets)

# Ensure that the consumer provides the partition information
consumer.provide_partition_info()
Expand Down Expand Up @@ -103,7 +104,8 @@ class MultiProcessConsumer(Consumer):
def __init__(self, client, group, topic, auto_commit=True,
auto_commit_every_n=AUTO_COMMIT_MSG_COUNT,
auto_commit_every_t=AUTO_COMMIT_INTERVAL,
num_procs=1, partitions_per_proc=0):
num_procs=1, partitions_per_proc=0,
child_loads_initial_offsets=False):

# Initiate the base consumer class
super(MultiProcessConsumer, self).__init__(
Expand Down Expand Up @@ -142,7 +144,8 @@ def __init__(self, client, group, topic, auto_commit=True,
args = (client.copy(),
group, topic, list(chunk),
self.queue, self.start, self.exit,
self.pause, self.size)
self.pause, self.size,
child_loads_initial_offsets)

proc = Process(target=_mp_consume, args=args)
proc.daemon = True
Expand Down
6 changes: 4 additions & 2 deletions kafka/consumer/simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,15 @@ def __init__(self, client, group, topic, auto_commit=True, partitions=None,
fetch_size_bytes=FETCH_MIN_BYTES,
buffer_size=FETCH_BUFFER_SIZE_BYTES,
max_buffer_size=MAX_FETCH_BUFFER_SIZE_BYTES,
iter_timeout=None):
iter_timeout=None,
load_initial_offsets=False):
super(SimpleConsumer, self).__init__(
client, group, topic,
partitions=partitions,
auto_commit=auto_commit,
auto_commit_every_n=auto_commit_every_n,
auto_commit_every_t=auto_commit_every_t)
auto_commit_every_t=auto_commit_every_t,
load_initial_offsets=load_initial_offsets)

if max_buffer_size is not None and buffer_size > max_buffer_size:
raise ValueError("buffer_size (%d) is greater than "
Expand Down