fix: Increase upper bound on marshmallow-sqlalchemy#2191
Merged
dpgaspar merged 4 commits intodpgaspar:masterfrom Feb 15, 2024
Merged
fix: Increase upper bound on marshmallow-sqlalchemy#2191dpgaspar merged 4 commits intodpgaspar:masterfrom
dpgaspar merged 4 commits intodpgaspar:masterfrom
Conversation
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2191 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 72 72
Lines 8990 8990
=======================================
Hits 7166 7166
Misses 1824 1824
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dpgaspar
approved these changes
Feb 15, 2024
Owner
|
Thank you @spike77453 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This increases the maximum allowed version of marshmallow-sqlalchemy to 0.28.x: marshmallow-sqlalchemy < 0.28.1 no longer works on Python 3.12 since it still uses distutils which was removed from Python (see PEP 632). This in turn means that Flask-AppBuilder currently doesn't work on Python 3.12 out of the box.
In marshmallow-sqlalchemy >= 0.28.1
distutils.version.LooseVersionwas replaced withpackaging.version.Version: marshmallow-code/marshmallow-sqlalchemy@1826a47Similar changes have been previously submitted: #1905
ADDITIONAL INFORMATION