feat: Added authentik as new identity provider#2168
feat: Added authentik as new identity provider#2168dpgaspar merged 8 commits intodpgaspar:masterfrom
Conversation
Yoyasp
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2168 +/- ##
=======================================
Coverage 79.31% 79.32%
=======================================
Files 72 72
Lines 8974 9007 +33
=======================================
+ Hits 7118 7145 +27
- Misses 1856 1862 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Made the URI configurable - Prevents malicous tokens from providing a fake jwks - Fixed minor flake8 error
|
Some how flake8 keeps giving me errors in the CI pipeline, however i dont get any errors while running flake8 on my dev host... |
dpgaspar
left a comment
dpgaspar
left a comment
There was a problem hiding this comment.
Sorry for the delay, please remove the requests dependency
forget it we already depend on it, I'll open a PR to include it on extras |
| resp = requests.get(jwks_url) | ||
| if resp.status_code == 200: | ||
| return resp.json() | ||
| return False |
There was a problem hiding this comment.
A bit late to the game but I am incorporating latest FAB changes to Airflow. I guess this should be a {} rather than False (or the return type should be dict | bool (but empty dict is likely better as it is Falsey value anyway.
There was a problem hiding this comment.
...
You are right.
I don't know how I missed that 😧
4 participants
Description
Added Authentik as new identity provider.
This PR includes:
ADDITIONAL INFORMATION