Skip to content

Comments

chore: remove email_validator constraint#2167

Merged
dpgaspar merged 4 commits intodpgaspar:masterfrom
marcuslimdw:remove-email-validator-constraint
Feb 15, 2024
Merged

chore: remove email_validator constraint#2167
dpgaspar merged 4 commits intodpgaspar:masterfrom
marcuslimdw:remove-email-validator-constraint

Conversation

@marcuslimdw
Copy link
Contributor

@marcuslimdw marcuslimdw commented Nov 22, 2023

Description

email-validator is a transitive dependency (of WTForms), but the <2 constraint isn't actually necessary.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f00efc) 79.71% compared to head (757aa98) 79.57%.
Report is 2 commits behind head on master.

❗ Current head 757aa98 differs from pull request most recent head feedc6a. Consider uploading reports for the commit feedc6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
- Coverage   79.71%   79.57%   -0.15%     
==========================================
  Files          72       72              
  Lines        8990     8982       -8     
==========================================
- Hits         7166     7147      -19     
- Misses       1824     1835      +11     
Flag Coverage Δ
python 79.57% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar self-requested a review January 25, 2024 14:20
@marcuslimdw marcuslimdw requested a review from dpgaspar February 6, 2024 22:28
@dpgaspar dpgaspar merged commit fb40d73 into dpgaspar:master Feb 15, 2024
@marcuslimdw marcuslimdw deleted the remove-email-validator-constraint branch February 18, 2024 11:02
markjm pushed a commit to markjm/Flask-AppBuilder that referenced this pull request Aug 22, 2025
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants