Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
- Coverage 74.50% 73.84% -0.66%
==========================================
Files 72 72
Lines 8970 8695 -275
==========================================
- Hits 6683 6421 -262
+ Misses 2287 2274 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
|
Thanks for the fix. Do you happen to know under which conditions Azure choose to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep backward compatibility with Azure, caused by this breaking change: #2121
although
id_tokendoes not include anupnfield, it can optionally be included.https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference
On this change we use
upnif it exists else useemailADDITIONAL INFORMATION