docs: improve LDAP auth auth_roles_mapping#2149
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2149 +/- ##
===========================================
- Coverage 74.50% 48.38% -26.12%
===========================================
Files 72 72
Lines 8970 8695 -275
===========================================
- Hits 6683 4207 -2476
- Misses 2287 4488 +2201
Flags with carried forward coverage won't be shown. Click here to find out more. |
eladkal
reviewed
Oct 25, 2023
docs/security.rst
Outdated
Comment on lines
140
to
141
| You can give FlaskAppBuilder roles based on LDAP roles/memberships. (note, this requires AUTH_LDAP_SEARCH to be set) | ||
| Note that by default roles will be evaluated based on LDAP memberships. |
There was a problem hiding this comment.
Worth also to note that the code looks for exact match of the ldap string. The whole string.
Matching only CN or OU as substring does not work.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Help for: #1641
Improves LDAP auth docs
ADDITIONAL INFORMATION