fix: Remove erroring endpoint "/login/<provider>/<register>" from AuthOAut…#2120
Merged
dpgaspar merged 3 commits intodpgaspar:masterfrom Oct 11, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
+ Coverage 73.36% 78.66% +5.30%
==========================================
Files 72 72
Lines 8687 8686 -1
==========================================
+ Hits 6373 6833 +460
+ Misses 2314 1853 -461
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hView
Description
Keyword argument
registerwas removed fromAuthOAuthView.loginas part of #1707. However, the endpoint/login/<provider>/<register>/is still exposed, resulting in a 500 error whenever it is called:This PR fixes this error and any calls to that endpoint will properly return a 404 instead.
ADDITIONAL INFORMATION