Skip to content

release: 3.4.0 RC1#1726

Closed
dpgaspar wants to merge 1 commit intomasterfrom
release/3.4.0rc1
Closed

release: 3.4.0 RC1#1726
dpgaspar wants to merge 1 commit intomasterfrom
release/3.4.0rc1

Conversation

@dpgaspar
Copy link
Owner

Description

Release 3.4.0 RC1

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1726 (eea3500) into master (a1a4f80) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          56       56           
  Lines        8114     8114           
=======================================
  Hits         6232     6232           
  Misses       1882     1882           
Flag Coverage Δ
python 76.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a4f80...eea3500. Read the comment docs.

@shawnzhu
Copy link
Contributor

shawnzhu commented Nov 8, 2021

May I ask for including an emergency fix of #1732 into this release? it just need to lock down wtforms<3.0.0

@dpgaspar
Copy link
Owner Author

dpgaspar commented Nov 8, 2021

@shawnzhu guessing that #1733 fixes the issue without having to lock down wforms, can you confirm?

@shawnzhu
Copy link
Contributor

shawnzhu commented Nov 9, 2021

@dpgaspar no, it still need to lock down wtforms since there're several break changes in wtforms 3.0.0 where deprecated APIs are removed. see https://github.com/wtforms/wtforms/blob/1c369091a7b2712bf87213a79fd210bde74f9681/docs/whats_new.rst#deprecated-apis

it may takes time to include all fixes for supporting wtfforms 3.0.0 in an emergency fix plus it may not be enough time to test all fixes. I personally suggest locking down wtfforms to <3.0.0 to unblock all users immedately then testing fixes.

Update: it (i.e., apache superset 1.3.2) does work when locking down wtforms to 2.3.3

@dpgaspar dpgaspar closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants