other: Redirect to the referrer URL when changing locale.

[tianhe1986]

Signed-off-by: tianhe1986 w1s2j3229@163.com

Description

In most case, users hope just refreshing the current page after changing locale.
However, not all pages call update_redirect, turning out it will jump to other page at the top of the page history stack.
For example, this issue in apache superset

ADDITIONAL INFORMATION

• Has associated issue:
• Is CRUD MVC related.
• Is Auth, RBAC security related.
• Changes the security db schema.
• Introduces new feature
• Removes existing feature

[codecov]

Codecov Report

Merging #1679 (f3703fa) into master (fdf5784) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head f3703fa differs from pull request most recent head bad9fb5. Consider uploading reports for the commit bad9fb5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   76.67%   76.44%   -0.24%     
==========================================
  Files          55       55              
  Lines        8091     8037      -54     
==========================================
- Hits         6204     6144      -60     
- Misses       1887     1893       +6     

Flag	Coverage Δ
python	76.44% <100.00%> (-0.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
flask_appbuilder/babel/views.py	94.73% <100.00%> (+1.87%)	⬆️
flask_appbuilder/models/sqla/filters.py	76.66% <0.00%> (-4.18%)	⬇️
flask_appbuilder/views.py	65.26% <0.00%> (-0.85%)	⬇️
flask_appbuilder/models/base.py	73.74% <0.00%> (-0.30%)	⬇️
flask_appbuilder/security/views.py	61.74% <0.00%> (-0.28%)	⬇️
flask_appbuilder/exceptions.py	100.00% <0.00%> (ø)
flask_appbuilder/validators.py	100.00% <0.00%> (ø)
flask_appbuilder/security/forms.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba517a...bad9fb5. Read the comment docs.

[dpgaspar]

Thank you for the PR, left a couple of questions

[dpgaspar]

The LocaleView.index is already calling update_redirect why updating it again? because we need to update it with the referrer?

Also would it make more sense to add the update_redirect to Superset?

[tianhe1986]

The LocaleView.index is already calling update_redirect why updating it again? because we need to update it with the referrer?

Yes, updating it with the referrer before calling update_redirect would ensure it redirects back to the referrer page.

Also would it make more sense to add the update_redirect to Superset?

Surely you are right:) It is just a bit tough to add update_redirect in every related view, and the same case even with
build-in pages, not only Superset.

For example, with the URL "/login/", that is, login function at subclass of class AuthView, e.g class AuthDBView, it also does not call the update_redirect and would redirect to other page while changing locale.

[junlincc]

Thank you for the contribution! Would love to get it through. @villebro want to chime in?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you