Skip to content

[api] [mvc] Fix, make like filters case insensitive #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpgaspar merged 2 commits into from
Apr 1, 2020
Merged

[api] [mvc] Fix, make like filters case insensitive #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb94b8b
[api] [mvc] Fix, make like filters case insensitive
dpgaspar Mar 30, 2020
290937e
Merge branch 'master' into fix/make-like-filters-ci
dpgaspar Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flask_appbuilder/models/sqla/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class FilterStartsWith(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(field.like(value + "%"))
return query.filter(field.ilike(value + "%"))


class FilterNotStartsWith(BaseFilter):
Expand All @@ -90,7 +90,7 @@ class FilterNotStartsWith(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(~field.like(value + "%"))
return query.filter(~field.ilike(value + "%"))


class FilterEndsWith(BaseFilter):
Expand All @@ -99,7 +99,7 @@ class FilterEndsWith(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(field.like("%" + value))
return query.filter(field.ilike("%" + value))


class FilterNotEndsWith(BaseFilter):
Expand All @@ -108,7 +108,7 @@ class FilterNotEndsWith(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(~field.like("%" + value))
return query.filter(~field.ilike("%" + value))


class FilterContains(BaseFilter):
Expand All @@ -117,7 +117,7 @@ class FilterContains(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(field.like("%" + value + "%"))
return query.filter(field.ilike("%" + value + "%"))


class FilterNotContains(BaseFilter):
Expand All @@ -126,7 +126,7 @@ class FilterNotContains(BaseFilter):

def apply(self, query, value):
query, field = get_field_setup_query(query, self.model, self.column_name)
return query.filter(~field.like("%" + value + "%"))
return query.filter(~field.ilike("%" + value + "%"))


class FilterEqual(BaseFilter):
Expand Down