Fix, make single db call on menu get data#1157
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 71.57% 71.67% +0.09%
==========================================
Files 44 44
Lines 5964 5998 +34
==========================================
+ Hits 4269 4299 +30
- Misses 1695 1699 +4
Continue to review full report at Codecov.
|
Owner
Author
|
@nytai making a single db call ^^^ |
nytai
approved these changes
Oct 9, 2019
Contributor
nytai
left a comment
nytai
left a comment
There was a problem hiding this comment.
👍 thanks for implementing this!
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance on menu endpoint, make a single db call