Skip to content

Conversation

@dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Sep 26, 2019

Fixed:

  • Empty LANGUAGES definition crash

  • Remove drop down language selection if LANGUAGES is empty or just one

  • Fix API requesting a non existing language crash

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #1147 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   68.83%   69.05%   +0.22%     
==========================================
  Files          45       45              
  Lines        6248     6254       +6     
==========================================
+ Hits         4301     4319      +18     
+ Misses       1947     1935      -12
Impacted Files Coverage Δ
flask_appbuilder/babel/manager.py 95.23% <100%> (+3.57%) ⬆️
flask_appbuilder/fieldwidgets.py 62.83% <0%> (+6.19%) ⬆️
flask_appbuilder/babel/views.py 100% <0%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3e6bc...f7cc6de. Read the comment docs.

@dpgaspar dpgaspar merged commit f80fae9 into master Sep 26, 2019
@dpgaspar dpgaspar deleted the fix/babel-empty-definition branch September 26, 2019 13:35
@dpgaspar dpgaspar mentioned this pull request Sep 27, 2019
@dpgaspar dpgaspar mentioned this pull request Oct 16, 2019
@nytai nytai mentioned this pull request Nov 6, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants