Add autofocus attribute to login page.

[kuckjwi0928]

Improvement, Add autofocus attribute to login page.
related issue: #1131

[codecov]

Codecov Report

Merging #1132 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1132   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files          55       55           
  Lines        8603     8603           
=======================================
  Hits         6537     6537           
  Misses       2066     2066

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f421e9d...9619c7b. Read the comment docs.

[MarcusSorealheis]

Did not see this when I opened this PR: #1135

[MarcusSorealheis]

You can ignore mine and just consider the approach but I recommend one thing, use cursor: auto because I have observed some browser issues with autofocus in the past.

[MarcusSorealheis]

Better support, see here: https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#Browser_compatibility

[MarcusSorealheis]

and here: https://caniuse.com/#feat=autofocus

[kuckjwi0928]

@MarcusSorealheis

#loginbox #username {
	cursor: auto;
}

You mean this code?

But i've applied it, but it's not moving the focus

Isn't this property just specifying the shape of the cursor?

https://www.w3schools.com/cssref/pr_class_cursor.asp

[MarcusSorealheis]

autofocus is probably right. I’m on my phone. Ignore my comment. I just ran into autofocus issues once before.

On Fri, Sep 20, 2019 at 4:34 PM Marcus Eagan ***@***.***> wrote: Maybe that’s the wrong property. I need to revisit. My apologies. On Fri, Sep 20, 2019 at 4:25 PM kuckjwi ***@***.***> wrote: > @MarcusSorealheis <https://github.com/MarcusSorealheis> > > #loginbox #username { > cursor: auto; > } > > You mean this code? > > But i've applied it, but it's not moving the focus > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1132?email_source=notifications&email_token=AAR6TSD5KRKNKUM7YPLYV63QKVLVRA5CNFSM4IYXO4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IELJI#issuecomment-533743013>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAR6TSBVRW5WQNBTKHMBS53QKVLVRANCNFSM4IYXO4SQ> > . > -- Marcus Eagan --

Marcus Eagan

[MarcusSorealheis]

Maybe that’s the wrong property. I need to revisit. My apologies.

On Fri, Sep 20, 2019 at 4:25 PM kuckjwi ***@***.***> wrote: @MarcusSorealheis <https://github.com/MarcusSorealheis> #loginbox #username { cursor: auto; } You mean this code? But i've applied it, but it's not moving the focus — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1132?email_source=notifications&email_token=AAR6TSD5KRKNKUM7YPLYV63QKVLVRA5CNFSM4IYXO4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IELJI#issuecomment-533743013>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR6TSBVRW5WQNBTKHMBS53QKVLVRANCNFSM4IYXO4SQ> .

-- Marcus Eagan

[dpgaspar]

Tested it and looks good