Skip to content

Implement correct :disabled support for fieldsets and nested form controls #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dperini merged 3 commits into from
Sep 27, 2024
+45 −4
Merged

Implement correct :disabled support for fieldsets and nested form controls #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
916aeb4
Update disabled pseudo-classes test from WPT
camchenry Aug 29, 2024
0658d64
Implement nested fieldset support for disabled
camchenry Aug 29, 2024
b3cfd88
Add new line
camchenry Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/nwsapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,10 +1123,31 @@
')){' + source + '}';
break;
case 'disabled':
// https://www.w3.org/TR/html5/forms.html#enabling-and-disabling-form-controls:-the-disabled-attribute
source = 'if((("form" in e||/^optgroup$/i.test(e.localName))&&"disabled" in e&&' +
'(e.disabled===true||(n=s.ancestor("fieldset",e))&&(n=s.first("legend",n))&&!n.contains(e))' +
')){' + source + '}';
// https://html.spec.whatwg.org/#enabling-and-disabling-form-controls:-the-disabled-attribute
source = 'if((("form" in e||/^optgroup$/i.test(e.localName))&&"disabled" in e)){' +
// F is true if any of the fieldset elements in the ancestry chain has the disabled attribute specified
// L is true if the first legend element of the fieldset contains the element
'var x=0,N=[],F=false,L=false;' +
'if(!(/^(optgroup|option)$/i.test(e.localName))){' +
Copy link
Contributor Author

@camchenry camchenry Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit messy, but optgroup has different definitions for disabled, as the HTML spec notes in the disabled attribute documentation:

The disabled attribute for option elements and the disabled attribute for optgroup elements are defined separately.

We shouldn't take into account fieldset/legend for optgroup/option, so we skip over code related to that here.

'n=e.parentElement;' +
'while(n){' +
'if(n.localName=="fieldset"){' +
'N[x++]=n;' +
'if(n.disabled===true){' +
'F=true;' +
'break;' +
'}' +
'}' +
'n=n.parentElement;' +
'}' +
'for(var x=0;x<N.length;x++){' +
'if((n=s.first("legend",N[x]))&&n.contains(e)){' +
'L=true;' +
'break;' +
'}' +
'}' +
'}' +
'if(e.disabled===true||(F&&!L)){' + source + '}}';
break;
case 'read-only':
source =
Expand Down
20 changes: 20 additions & 0 deletions test/w3c/html/semantics/selectors/pseudo-classes/disabled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,24 @@
var input = document.createElement("input");
input.setAttribute("disabled", "disabled");
testSelectorIdsMatch(":disabled", ["button1", "input2", "select2", "optgroup2", "option2", "textarea2", "fieldset2", "clubname", "clubnum"], "':disabled' should not match elements not in the document");

var fieldset = document.createElement("fieldset");
fieldset.id = "fieldset_nested";
fieldset.innerHTML = `
<input id=input_nested>
<button id=button_nested>button nested</button>
<select id=select_nested>
<optgroup label="options" id=optgroup_nested>
<option value="options" id=option_nested>option nested</option>
</optgroup>
</select>
<textarea id=textarea_nested>textarea nested</textarea>
<object id=object_nested></object>
<output id=output_nested></output>
<fieldset id=fieldset_nested2>
<input id=input_nested2>
</fieldset>
`;
document.getElementById("fieldset2").appendChild(fieldset);
testSelectorIdsMatch("#fieldset2 :disabled", ["clubname", "clubnum", "fieldset_nested", "input_nested", "button_nested", "select_nested", "textarea_nested", "fieldset_nested2", "input_nested2"], "':disabled' should match elements that are appended to a disabled fieldset dynamically");
</script>