Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxelib 3.3.0 has a different lib name #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jozefchutka
Copy link

No description provided.

@po8rewq
Copy link

po8rewq commented Feb 7, 2017

Aren't we going to break compatibility with pre 3.3.0 versions?

Instead we should do something like:

set -- "$VERSION"
IFS=","; declare -a Array=($*)
if [ "${Array[0]}" -gt "3" ] ||
	([ "${Array[0]}" -eq "3" ] &&
	([ "${Array[1]}" -gt "3" ] ||
	([ "${Array[1]}" -eq "3" ] && [ "${Array[2]}" -gt "0" ]))); then
	URL="http://lib.haxe.org/files/3.0/haxelib-$VERSION.zip"
else
	URL="http://lib.haxe.org/files/3.0/haxelib_client-$VERSION.zip"
fi

What do you think?

@po8rewq
Copy link

po8rewq commented Feb 8, 2017

Actually, it would be better to always use this url: https://github.com/HaxeFoundation/haxelib/archive/
There is a tag per version. Some are missing, but the majors are here.

See my changes on config.sh: po8rewq@15c0615

I didn't do the necessary changes for hvm versions haxelib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants