Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UUIDs and URIs in code command #169

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

robertgzr
Copy link
Contributor

a864366 changed the implementation of
find_entry to work on the new Needle type, but when calling into it from the
code subcommand the provided string was only passed as a Needle::Name when
in fact also UUIDs are allowed.

Remedy this by parsing the first argument in the same way as with the get
command, which also enables passing URIs

Signed-off-by: Robert Günzler [email protected]

a864366 changed the implementation of
`find_entry` to work on the new `Needle` type, but when calling into it from the
`code` subcommand the provided string was only passed as a `Needle::Name` when
in fact also UUIDs are allowed.

Remedy this by parsing the first argument in the same way as with the `get`
command, which also enables passing URIs

Signed-off-by: Robert Günzler <[email protected]>
@doy doy merged commit 5f5dd37 into doy:main May 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants