fix(get-dependency-list): add glob to dependency list and match existing behaviour on Windows.

[neverendingqs]

Resolves #74 (comment), #75.

• f6bb143 - glob is used at:

  • serverless-plugin-include-dependencies/get-dependency-list.js

    Line 9 in 0c0fc72

    const glob = require('glob');

  • serverless-plugin-include-dependencies/include-dependencies.js

    Line 7 in 0c0fc72

    const glob = require('glob');

• b777583 - based on the code today and glob@8 notes, I think this matches pre-[email protected] behaviour

It's not explicitly spelled out in the Serverless documentation, but it looks like package.patterns should always be using /s anyway, so I don't think

serverless-plugin-include-dependencies/include-dependencies.js

Lines 59 to 65 in 0c0fc72

	const files = [...new Set(this.getPatterns().filter(pattern => !pattern.startsWith('!') && !pattern.includes('node_modules'))
	.map(modulePath => glob.sync(modulePath, {
	nodir: true,
	ignore: path.join(modulePath, 'node_modules', '**'),
	absolute: true
	})
	).flat().map(file => file.replaceAll('\\', '/')))];

needs to be updated with the same change.

Open to feedback!

---

Quality notes:

• Functional:
  • Was missing all node_modules/ files in Serverless package before this change, and this change pulled it in
  • Unit tests pass (fix(get-dependency-list): add glob to dependency list and match existing behaviour on Windows. neverendingqs/serverless-plugin-include-dependencies#2)
    • If interested, I can submit the CI commit as another PR as well (chore(workflows): add ci. neverendingqs/serverless-plugin-include-dependencies#1)
      • I couldn't get unit tests running locally 😅
• Performance:
  • N/A
• Cost:
  • N/A
• Security:
  • N/A
• DevOps:
  • N/A
• Docs:
  • N/A