Unable to pass include information to istanbul

[aukevanleeuwen]

I was trying to make sure that a certain file was loaded first by isparta / istanbul by passing --include path/to/first.js --include **/*.js, however this didn't seem to 'make it to istanbul'. It seems to go wrong on this line:

isparta/src/cli.js

Line 189 in 8cd2944

includes: opts.includes || config.instrumentation.extensions()

Since ops.includes is read there where the actual option is called ops.include as far as I can tell. I didn't open a pull request since I was unsure whether you wanted to make the cli argument --includes (that would be nicely symmetrical with --excludes) or that you wanted to fix this on the line mentioned above. I would guess the former, however the commandline argument is a 'public api' of course. Then again: I don't think those includes are working anyway.

[aukevanleeuwen]

Probably broke in 941dc51.

[douglasduteil]

Ooops Right !
I'm correcting this typo right now sry

[douglasduteil]

Fixed in [email protected]

[aukevanleeuwen]

👍 thanks.