Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: field indexes getting overridden when appending #291

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Conversation

doug-martin
Copy link
Owner

Fix for #290

When creating the columnMap with multiple levels of embedded structs the append was mutating the original fieldIndex slice causing the fieldIndex for each column to be incorrect.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #291 (27530d6) into master (e7dd58b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          61       61           
  Lines        3350     3353    +3     
=======================================
+ Hits         3243     3246    +3     
  Misses         91       91           
  Partials       16       16           
Flag Coverage Δ
unittests 96.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/util/column_map.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dd58b...27530d6. Read the comment docs.

@doug-martin doug-martin merged commit 606f5c0 into master Aug 3, 2021
@doug-martin doug-martin deleted the issue290 branch October 16, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant