feat: allow untagged fields to be ignored #285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 96.77% 96.79% +0.01%
==========================================
Files 60 60
Lines 3319 3335 +16
==========================================
+ Hits 3212 3228 +16
Misses 91 91
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This adds a `SetIgnoreUntaggedFields` function which sets the behavior when encountering struct fields that do not have a db tag. By default this is false; if set to true any field without a db tag will not be targeted by Select or Scan operations.
internal/util/column_map.go
Outdated
| @@ -111,3 +111,13 @@ func getColumnName(f *reflect.StructField, dbTag tag.Options) string { | |||
| } | |||
| return dbTag.Values()[0] | |||
| } | |||
|
|
|||
| func shouldIgnoreField(dbTag tag.Options) bool { | |||
| if dbTag == "-" { | |||
There was a problem hiding this comment.
Changing this back to dbTag.Equals("-") and use the dbTag.IsEmpty() on line 118 will fix the coverage issues. Then I'll merge and release
There was a problem hiding this comment.
Done. I tossed the change on as an additional commit to avoid making the delta harder to review; please feel free to squash when merging.
Per #284
This adds a
SetIgnoreUntaggedFieldsfunction which sets the behavior whenencountering struct fields that do not have a db tag. By default this is
false; if set to true any field without a db tag will not be targeted by
Select or Scan operations.